fix(frontend/kanban): honor server bucket redirect when dropping a recurring task on Done - #2621
Conversation
github-actions
Bot
added
area/frontend
Preview DeploymentPreview deployments for this PR are available at:
The preview environment will start automatically on first visit. Subsequent pushes to this PR will update the Run locally with Dockerdocker pull ghcr.io/go-vikunja/vikunja:pr-2621
docker run -p 3456:3456 ghcr.io/go-vikunja/vikunja:pr-2621Last updated for commit c68649f |
| test('Recurring task dropped on done bucket moves back to the default bucket', async ({authenticatedPage: page}) => { | ||
| // Reproduces https://github.com/go-vikunja/vikunja/issues/2618 | ||
| const projects = await ProjectFactory.create(1) | ||
| await ProjectViewFactory.create(1, { |
There was a problem hiding this comment.
no need to seed and then override again later
There was a problem hiding this comment.
Implemented in 830b546 — dropped the redundant second seed by setting done_bucket_id: 2 on the initial view create and pinning bucket IDs via {increment}.
|
auggie review |
🤖 Augment PR SummarySummary: Fixes a Kanban drag/drop edge case where recurring tasks dragged into the Done bucket are immediately redirected by the backend to another bucket, but the frontend kept rendering the card in Done until refresh. Changes:
Technical Notes: The fix relies on honoring the 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
2 participants
When a recurring task is dragged to the Done bucket, the backend correctly resets the task and returns a different
bucketIdin the response, but the frontend ignored that redirect — the card stayed visually in Done until the page was refreshed.The guard in
ProjectKanban.vuethat was meant to detect a server-side bucket change was tautologically false becausenewTask.bucketIdwas assigned from the response one line before the comparison. Reordered so the comparison fires on the pre-response bucket.Fixes #2618